Moves ash::user::LoginStatus to ash/common

Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org

Committed: https://crrev.com/e79274a529e13ea233610f6359fbbbf8cb361db6
Cr-Commit-Position: refs/heads/master@{#398488}

[sky, 2016-06-07 22:11:48]

Description was changed from

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org
==========

to

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org
==========

[sky, 2016-06-07 22:11:49]

sky@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-06-08 00:14:07]

LGTM with one question about the rest of the file.

https://codereview.chromium.org/2041233005/diff/20001/ash/ash.gyp
File ash/ash.gyp (right):

https://codereview.chromium.org/2041233005/diff/20001/ash/ash.gyp#newcode64
ash/ash.gyp:64: 'common/login_status.h',
If you're willing to wait until my SessionStateDelegate move lands you'll be
able to move the entire ash/system/user/login_status.h file. 

If you need this move before then, can you either move the rest of the file in a
later CL, or file a bug for me to do it?

Or maybe the remaining function could become a static method on UserView?

https://codereview.chromium.org/2041233005/diff/20001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right):

https://codereview.chromium.org/2041233005/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:339: // Ash specific
LOGGED_IN state.
nit: LOGGED_IN -> LoginStatus. Or just delete the comment; I don't think it's
that helpful.

[James Cook, 2016-06-08 00:16:36]

(I misunderstood when you initially mentioned LoginStatus and I thought you
meant the whole file. Apologies for not asking about the rest of the file then.)

[sky, 2016-06-08 04:01:58]

https://codereview.chromium.org/2041233005/diff/20001/ash/ash.gyp
File ash/ash.gyp (right):

https://codereview.chromium.org/2041233005/diff/20001/ash/ash.gyp#newcode64
ash/ash.gyp:64: 'common/login_status.h',
On 2016/06/08 00:14:06, James Cook wrote:
> If you're willing to wait until my SessionStateDelegate move lands you'll be
> able to move the entire ash/system/user/login_status.h file. 
> 
> If you need this move before then, can you either move the rest of the file in
a
> later CL, or file a bug for me to do it?
> 
> Or maybe the remaining function could become a static method on UserView?

I like that better as getting a localized string for the login status is
separate from the enum. I didn't add a TODO here as we can figure out the right
thing when moving more of the ash/system/user directory.

https://codereview.chromium.org/2041233005/diff/20001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right):

https://codereview.chromium.org/2041233005/diff/20001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:339: // Ash specific
LOGGED_IN state.
On 2016/06/08 00:14:06, James Cook wrote:
> nit: LOGGED_IN -> LoginStatus. Or just delete the comment; I don't think it's
> that helpful.

Done.

[sky, 2016-06-08 04:02:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-08 04:02:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2041233005/#ps40001
(title: "merge && feedback")

[commit-bot: I haz the power, 2016-06-08 04:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041233005/40001

[commit-bot: I haz the power, 2016-06-08 04:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 04:23:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-06-08 04:43:21]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-08 04:43:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2041233005/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2016-06-08 04:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041233005/60001

[commit-bot: I haz the power, 2016-06-08 05:39:14]

Description was changed from

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org
==========

to

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org
==========

[commit-bot: I haz the power, 2016-06-08 05:39:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-08 05:40:59]

Description was changed from

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org
==========

to

==========
Moves ash::user::LoginStatus to ash/common

BUG=581868
TEST=none
R=jamescook@chormium.org

Committed: https://crrev.com/e79274a529e13ea233610f6359fbbbf8cb361db6
Cr-Commit-Position: refs/heads/master@{#398488}
==========

[commit-bot: I haz the power, 2016-06-08 05:41:00]

Patchset 4 (id:??) landed as
https://crrev.com/e79274a529e13ea233610f6359fbbbf8cb361db6
Cr-Commit-Position: refs/heads/master@{#398488}