Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2041233003: PPC/AIX: [heap] Uncommit unused large object page memory. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/AIX: [heap] Uncommit unused large object page memory. Port d61a5c376ba51145dc4684e39d5d3a9ce75bcfa6 Original commit message: As a first step I uncommit the memory on the main thread. Also to measure impact and stability of that optimization. In a follow-up CL, the uncommitting should be moved on the concurrent thread. R=jochen@chromium.org, hpayer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/04b655c6e94b65046d6f2b5a7fb1482736a15c1f Cr-Commit-Position: refs/heads/master@{#37332}

Patch Set 1 #

Patch Set 2 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/base/platform/platform-aix.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-07 16:05:34 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-07 18:22:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233003/20001
4 years, 6 months ago (2016-06-07 18:22:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16683)
4 years, 6 months ago (2016-06-07 18:26:21 UTC) #6
JaideepBajwa
ptal
4 years, 5 months ago (2016-06-27 22:06:38 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-28 13:01:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2041233003/20001
4 years, 5 months ago (2016-06-28 13:05:49 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 13:28:32 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 13:30:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04b655c6e94b65046d6f2b5a7fb1482736a15c1f
Cr-Commit-Position: refs/heads/master@{#37332}

Powered by Google App Engine
This is Rietveld 408576698