cros: Don't prefix test user profile.

cros: Don't prefix test user profile.

Prefixing test user profile breaks the assumption that
TestingProfile::kTestUserProfileDir is always in sync with
chrome::kTestUserProfileDir.

BUG=351243
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258114

[xiyuan, 2014-03-18 23:33:02]

It is not as scary as it first looks. The major changes are in
ProfileHelper::GetUserProfileDir and ProfileHelper::GetUserIdHashFromProfile,
which now skips adding 'u-' prefix for test user profile and legacy 'user'.

The other possible fix would be changing TestingProfile::kTestUserProfileDir
from a const to a function that returns 'u-test-user' when multi profile is
anbled and 'test-user' otherwise.

I prefer this CL over that though.
Let me what you think. Thanks.

[xiyuan, 2014-03-19 02:26:27]

The following tests needs to be patched with the CL:
LoginUserTest.UserPassed,
PrefsTabHelperBrowserTest.WebPrefs 
ProfileManagerCrOSBrowserTest.GetLastUsedProfile

Sort of undoing some of the work in r256806. But I think it makes sense because
if a test uses 'test-user' or 'user' for its profile, it probably behave not
very differently whether multi profile or not.

[Nikita (slow), 2014-03-19 10:50:23]

So this also fixes ExtensionsStartupTest?

[xiyuan, 2014-03-19 14:51:43]

On 2014/03/19 10:50:23, Nikita Kostylev wrote:
> So this also fixes ExtensionsStartupTest?

Yes. With the CL, the test passes regardless of whether multiprofile is on or
not. 

Do you want to use parameterized test as the other CL? I can do that too. I did
not because it should make no difference for ExtensionsStartupTest now.

[Nikita (slow), 2014-03-19 14:58:03]

I see. Hopefully we can remove this as soon as --login-profile=user is not used
anymore.

lgtm

thanks for finding the root cause of this.

[xiyuan, 2014-03-19 16:19:40]

Owners' approval please?

noms@: c/b/profiles/profile_manager_browsertest.cc
mnissler@: c/b/ui/prefs/prefs_tab_helper_browsertest.cc
sky@: chrome/common/logging_chrome.cc

Thanks.

[noms (inactive), 2014-03-19 16:23:54]

profiles lgtm

[sky, 2014-03-19 17:30:07]

LGTM

[Mattias Nissler (ping if slow), 2014-03-19 17:47:01]

prefs LGTM

[xiyuan, 2014-03-19 18:01:27]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-03-19 18:04:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/204123002/20001

[commit-bot: I haz the power, 2014-03-19 19:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 19:40:37]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[xiyuan, 2014-03-19 20:00:16]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-03-19 20:01:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/204123002/20001

[commit-bot: I haz the power, 2014-03-19 21:52:30]

Change committed as 258114