third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h - Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h

Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compositor-worker-upstream-registration

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/DOMMatrix.cpp ('K') | « third_party/WebKit/Source/core/dom/DOMMatrix.cpp ('k') | third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp » ('j') | third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h

index 3f1b8fce503c79944579e0fb93137155ae976462..1332cb65afb0460569b7186e242ab05f7660c1f7 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h

+++ b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.h

@@ -6,7 +6,7 @@

#define CompositorMutableStateProvider_h

#include "platform/PlatformExport.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <cstdint>

@@ -26,7 +26,8 @@ public:

CompositorMutableStateProvider(cc::LayerTreeImpl*, CompositorMutations*);

~CompositorMutableStateProvider();

- PassOwnPtr<CompositorMutableState> getMutableStateFor(uint64_t elementId);

+ std::unique_ptr<CompositorMutableState> getMutableStateFor(uint64_t elementId);

jbroman 2016/06/08 14:59:38 Why all this code changing from OwnPtr to std::uni

majidvp 2016/06/08 21:50:09 I am using unique_ptr for the only call site of th

private:

cc::LayerTreeImpl* m_state;

CompositorMutations* m_mutations;