third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp - Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compositor-worker-upstream-registration

Patch Set: Use RAII pattern Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp ('k') | third_party/WebKit/Source/platform/graphics/CompositorMutator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

index bd06f90e472914a5fa516aaa1a9b69f4c5713813..0d0cb78dc279ca3d3cb18195404201bf9d63839e 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

@@ -16,7 +16,8 @@

#include "platform/graphics/CompositorMutableStateProvider.h"

#include "platform/graphics/CompositorMutation.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "wtf/OwnPtr.h"

+#include <memory>

namespace blink {

@@ -79,7 +80,7 @@ TEST_F(CompositorMutableStateTest, NoMutableState)

CompositorMutations mutations;

CompositorMutableStateProvider provider(hostImpl().active_tree(), &mutations);

- OwnPtr<CompositorMutableState> state(provider.getMutableStateFor(42));

+ std::unique_ptr<CompositorMutableState> state(provider.getMutableStateFor(42));

EXPECT_FALSE(state);

}

@@ -97,7 +98,7 @@ TEST_F(CompositorMutableStateTest, MutableStateNoMutableProperties)

CompositorMutations mutations;

CompositorMutableStateProvider provider(hostImpl().active_tree(), &mutations);

- OwnPtr<CompositorMutableState> state(provider.getMutableStateFor(42));

+ std::unique_ptr<CompositorMutableState> state(provider.getMutableStateFor(42));

EXPECT_FALSE(state);

}

@@ -129,7 +130,7 @@ TEST_F(CompositorMutableStateTest, MutableStateMutableProperties)

CompositorMutations mutations;

CompositorMutableStateProvider provider(hostImpl().active_tree(), &mutations);

- OwnPtr<CompositorMutableState> state(provider.getMutableStateFor(layer->element_id()));

+ std::unique_ptr<CompositorMutableState> state(provider.getMutableStateFor(layer->element_id()));

EXPECT_TRUE(state.get());

EXPECT_EQ(1.0, rootLayer()->Opacity());