third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js - Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js

Issue 2041193005: [compositorworker] compositor proxy mutation updates underlying layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compositor-worker-upstream-registration

Patch Set: raise if not initialized Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-worker-to-main.js ('k') | third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/visual-update.js » ('j') | third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js

diff --git a/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js b/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js

index b76769cd45c30e6ccac3781823dbe4ef4d431f01..aea2d920205b4b59cddcf67ca865c8beef42b034 100644

--- a/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js

+++ b/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js

@@ -1,10 +1,19 @@

onmessage = function(event) {

var proxy = event.data;

- proxy.opacity;

- proxy.disconnect();

- try {

- proxy.opacity;

- } catch (e) {

- postMessage(e.name);

+ var respond = function() {

+ if (!proxy.initialized) {

+ requestAnimationFrame(respond);

+ return;

+ }

+ proxy.opacity;

+ proxy.disconnect();

+ try {

+ proxy.opacity;

+ postMessage("Able to read mutable property after disconnect.");

+ } catch (e) {

+ postMessage(e.name);

+ }

}

+ requestAnimationFrame(respond);

}