[compositorworker] compositor proxy mutation updates underlying layers

third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/CompositorProxyClientImpl.h"
 
 #include "core/dom/CompositorProxy.h"
 #include "modules/compositorworker/CompositorWorkerGlobalScope.h"
 #include "platform/TraceEvent.h"
+#include "platform/graphics/CompositorMutableStateProvider.h"
 #include "web/CompositorMutatorImpl.h"
 #include "wtf/CurrentTime.h"
 
 namespace blink {
 
 CompositorProxyClientImpl::CompositorProxyClientImpl(CompositorMutatorImpl* mutator)
     : m_mutator(mutator)
     , m_globalScope(nullptr)
 {
 }
@@ skipping 15 matching lines @@
     m_mutator->registerProxyClient(this);
 }
 
 void CompositorProxyClientImpl::requestAnimationFrame()
 {
     TRACE_EVENT0("compositor-worker", "CompositorProxyClientImpl::requestAnimationFrame");
     m_requestedAnimationFrameCallbacks = true;
     m_mutator->setNeedsMutate();
 }
 
-bool CompositorProxyClientImpl::mutate(double monotonicTimeNow)
+bool CompositorProxyClientImpl::mutate(double monotonicTimeNow, CompositorMutableStateProvider* stateProvider)
 {
     if (!m_globalScope)
         return false;
 
     TRACE_EVENT0("compositor-worker", "CompositorProxyClientImpl::mutate");
     if (!m_requestedAnimationFrameCallbacks)
         return false;
 
+    updateMutableStateForCompositorProxies(stateProvider);

[jbroman, 2016/06/13 19:45:17]

Mind clarifying what's going on here? I think I get it (the state is only
available during the animation frame callbacks), but I think it bears some
explanation.

[majidvp, 2016/06/13 21:52:51]

Yes. Proxies may only mutate the tree during rAF. I will add a comment.

     m_requestedAnimationFrameCallbacks = executeAnimationFrameCallbacks(monotonicTimeNow);
+    updateMutableStateForCompositorProxies(nullptr);
 
     return m_requestedAnimationFrameCallbacks;
 }
 
 bool CompositorProxyClientImpl::executeAnimationFrameCallbacks(double monotonicTimeNow)
 {
     TRACE_EVENT0("compositor-worker", "CompositorProxyClientImpl::executeAnimationFrameCallbacks");
+
     // Convert to zero based document time in milliseconds consistent with requestAnimationFrame.
     double highResTimeMs = 1000.0 * (monotonicTimeNow - m_globalScope->timeOrigin());
-    const bool shouldReinvoke = m_globalScope->executeAnimationFrameCallbacks(highResTimeMs);
-    return shouldReinvoke;
+    return m_globalScope->executeAnimationFrameCallbacks(highResTimeMs);
+}
+
+void CompositorProxyClientImpl::updateMutableStateForCompositorProxies(CompositorMutableStateProvider* stateProvider)
+{
+    for (CompositorProxy* proxy : m_proxies)
+        proxy->takeCompositorMutableState(stateProvider ? stateProvider->getMutableStateFor(proxy->elementId()) : nullptr);
 }
 
 void CompositorProxyClientImpl::registerCompositorProxy(CompositorProxy* proxy)
 {
     m_proxies.add(proxy);
 }
 
 void CompositorProxyClientImpl::unregisterCompositorProxy(CompositorProxy* proxy)
 {
     m_proxies.remove(proxy);
 }
 
 } // namespace blink