Issue 2041153002: Use WeakPtrFactory in net::BidirectionalStream when posting task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2041153002: Use WeakPtrFactory in net::BidirectionalStream when posting task (Closed)

Created:
4 years, 6 months ago by xunjieli

Modified:
4 years, 6 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use WeakPtrFactory in net::BidirectionalStream when posting task This CL uses WeakPtrFactory to post task in net::BidirectionalStream. BUG=606394 TBR=mmenke@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2043863002 Cr-Commit-Position: refs/heads/master@{#398132} (cherry picked from commit 3b6ac70b2c8b7085bade85f46577677a45732005)

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -10 lines)			Patch
M	net/http/bidirectional_stream.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	net/http/bidirectional_stream.cc	View	8 chunks	+15 lines, -10 lines	0 comments	Download
M	net/http/bidirectional_stream_unittest.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

xunjieli

Hi Matt, this is to merge into M52, because we want to get it in ...

4 years, 6 months ago (2016-06-06 21:53:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041153002/1

4 years, 6 months ago (2016-06-06 22:07:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages