Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 204113007: Rewrite the fast/css/css2-system-fonts.html test (Closed)

Created:
6 years, 9 months ago by alancutter (OOO until 2018)
Modified:
6 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews
Visibility:
Public.

Description

Rewrite the fast/css/css2-system-fonts.html test This patch makes the fast/css/css2-system-fonts.html explicit about the font styles expected on each platform instead of just Mac. It also converts the test to be text only as the style information is now displayed in text format. This change is in preparation for a refactor of system font handling. BUG=353932 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169612

Patch Set 1 #

Patch Set 2 : Undelete Mac expectation, delete Win-XP expectation #

Messages

Total messages: 9 (0 generated)
alancutter (OOO until 2018)
6 years, 9 months ago (2014-03-19 07:36:52 UTC) #1
Timothy Loh
lgtm
6 years, 9 months ago (2014-03-20 00:15:22 UTC) #2
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 9 months ago (2014-03-20 01:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/204113007/20001
6 years, 9 months ago (2014-03-20 01:14:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 01:45:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 01:45:47 UTC) #6
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 9 months ago (2014-03-20 02:27:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/204113007/20001
6 years, 9 months ago (2014-03-20 02:28:01 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 04:06:01 UTC) #9
Message was sent while issue was closed.
Change committed as 169612

Powered by Google App Engine
This is Rietveld 408576698