Edit codereview.settings and cq.cfg for Git

Edit codereview.settings and cq.cfg for Git

R=sergeyberezin@chromium.org
TBR=tandrii@chromium.org
BUG=600446
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8c3211227fa768e8aa4172f8ae2f765c12566546

[Sergey Berezin, 2016-06-06 21:29:04]

lgtm

[Sergey Berezin, 2016-06-06 21:31:36]

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg
File infra/config/cq.cfg (left):

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg#oldcode7
infra/config/cq.cfg:7: svn_repo_url:
"svn://svn.chromium.org/chrome/trunk/tools/depot_tools"
Should it be replaced with git_repo_url: ...?

[agable, 2016-06-06 21:33:53]

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg
File infra/config/cq.cfg (left):

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg#oldcode7
infra/config/cq.cfg:7: svn_repo_url:
"svn://svn.chromium.org/chrome/trunk/tools/depot_tools"
On 2016/06/06 at 21:31:35, Sergey Berezin wrote:
> Should it be replaced with git_repo_url: ...?

You'd think, but in the absence of that it is just inferred from the config
location. At least, that's what we've done for other migrations so far...

[Sergey Berezin, 2016-06-06 21:48:31]

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg
File infra/config/cq.cfg (left):

https://codereview.chromium.org/2041123002/diff/1/infra/config/cq.cfg#oldcode7
infra/config/cq.cfg:7: svn_repo_url:
"svn://svn.chromium.org/chrome/trunk/tools/depot_tools"
On 2016/06/06 at 21:33:52, agable wrote:
> On 2016/06/06 at 21:31:35, Sergey Berezin wrote:
> > Should it be replaced with git_repo_url: ...?
> 
> You'd think, but in the absence of that it is just inferred from the config
location. At least, that's what we've done for other migrations so far...

Ah, cool, good to know. Thanks!

[agable, 2016-06-06 23:15:03]

Description was changed from

==========
Edit codereview.settings and cq.cfg for Git

R=sergeyberezin@chromium.org
BUG=600446
==========

to

==========
Edit codereview.settings and cq.cfg for Git

R=sergeyberezin@chromium.org
TBR=tandrii@chromium.org
BUG=600446
==========

[agable, 2016-06-06 23:17:15]

Description was changed from

==========
Edit codereview.settings and cq.cfg for Git

R=sergeyberezin@chromium.org
TBR=tandrii@chromium.org
BUG=600446
==========

to

==========
Edit codereview.settings and cq.cfg for Git

R=sergeyberezin@chromium.org
TBR=tandrii@chromium.org
BUG=600446

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/8c3211227fa768...
==========

[agable, 2016-06-06 23:17:17]

Committed patchset #1 (id:1) manually as
8c3211227fa768e8aa4172f8ae2f765c12566546.