sk_sp for gpu.

include/core/SkColorFilter.h

Index: include/core/SkColorFilter.h
diff --git a/include/core/SkColorFilter.h b/include/core/SkColorFilter.h
index 7ac335fb103677fb50037915e67b99b9dbbcf177..8d9bfd42e78784f27d2db9fa6c22a280ba11d28b 100644
--- a/include/core/SkColorFilter.h
+++ b/include/core/SkColorFilter.h
@@ -10,6 +10,7 @@
 
 #include "SkColor.h"
 #include "SkFlattenable.h"
+#include "SkRefCnt.h"
 #include "SkXfermode.h"
 
 class GrContext;
@@ -151,9 +152,7 @@ public:
      *
      *  A null return indicates that the color filter isn't implemented for the GPU backend.
      */
-    virtual const GrFragmentProcessor* asFragmentProcessor(GrContext*) const {
-        return nullptr;
-    }
+    virtual sk_sp<GrFragmentProcessor> asFragmentProcessor(GrContext*) const;

[bungeman-skia, 2016/06/08 18:22:16]

The issue here is that 'return nullptr;' with sk_sp implicitly logically turns
into

auto tmp = sk_sp<GrFragmentProcessor>(nullptr);
return_value = std::move(tmp);
tmp.~sk_sp<GrFragmentProcessor>();
return return_value;

which means destroying the local, which means that GrFragmentProcessor->unref()
needs to be accessible. Of course, the compiler never actually generates code
which does all of this, but the type system says that it has to be there.

I think the solution this issue (which shows up in a few places) is just to
define these out of line.

[bsalomon, 2016/06/08 19:50:50]

sgtm

 
     bool affectsTransparentBlack() const {
         return this->filterColor(0) != 0;