Activate the service isolate for all precompiled tests.

Activate the service isolate for all precompiled tests.

- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/bf4b3b37332e31ca5ec4b742b8143e128021d71b

[Cutch, 2016-06-07 16:48:39]

Description was changed from

==========
Activate the service isolate for all precompiled tests.

- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader

BUG=
==========

to

==========
Activate the service isolate for all precompiled tests.

- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader

BUG=
==========

[Cutch, 2016-06-07 16:48:39]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-06-07 17:06:32]

Fails precompiled + product with 

vm-service: Isolate creation error: Dart_LookupLibrary: library
'dart:vmservice_io' not found.
Unhandled exception:
Unsupported operation: Service did not return load port.


Presumably service isolate startup needs to be more selective if it is only
starting the service isolate for the load port and not for the vm service.

[Cutch, 2016-06-07 19:33:49]

On 2016/06/07 17:06:32, rmacnak wrote:
> Fails precompiled + product with 
> 
> vm-service: Isolate creation error: Dart_LookupLibrary: library
> 'dart:vmservice_io' not found.
> Unhandled exception:
> Unsupported operation: Service did not return load port.
> 
> 
> Presumably service isolate startup needs to be more selective if it is only
> starting the service isolate for the load port and not for the vm service.

PTAL

[rmacnak, 2016-06-07 19:43:40]

lgtm

[Cutch, 2016-06-07 19:47:48]

Description was changed from

==========
Activate the service isolate for all precompiled tests.

- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader

BUG=
==========

to

==========
Activate the service isolate for all precompiled tests.

- [x] We always need the load port now.
- [x] Fix a minor locking issue in Loader::~Loader

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bf4b3b37332e31ca5ec4b742b8143e128021d71b
==========

[Cutch, 2016-06-07 19:47:52]

Committed patchset #2 (id:20001) manually as
bf4b3b37332e31ca5ec4b742b8143e128021d71b (presubmit successful).