Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2041113002: skia/ext: do not assume Skia's headers include windows.h (Closed)

Created:
4 years, 6 months ago by hal.canary
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

skia/ext: do not assume Skia's headers include windows.h Committed: https://crrev.com/b765188e433cb3fea3ce675553269d8b660b8053 Cr-Commit-Position: refs/heads/master@{#398129}

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2016-06-06 (Monday) 16:06:28 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M skia/ext/platform_surface.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
hal.canary
PTAL
4 years, 6 months ago (2016-06-06 19:54:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041113002/1
4 years, 6 months ago (2016-06-06 19:54:50 UTC) #4
bungeman-skia
https://codereview.chromium.org/2041113002/diff/1/skia/ext/platform_surface.h File skia/ext/platform_surface.h (right): https://codereview.chromium.org/2041113002/diff/1/skia/ext/platform_surface.h#newcode11 skia/ext/platform_surface.h:11: #include <windows.h> Does this work if moved below the ...
4 years, 6 months ago (2016-06-06 20:04:50 UTC) #5
hal.canary
https://codereview.chromium.org/2041113002/diff/1/skia/ext/platform_surface.h File skia/ext/platform_surface.h (right): https://codereview.chromium.org/2041113002/diff/1/skia/ext/platform_surface.h#newcode11 skia/ext/platform_surface.h:11: #include <windows.h> On 2016/06/06 20:04:50, bungeman-skia wrote: > Does ...
4 years, 6 months ago (2016-06-06 20:07:05 UTC) #6
bungeman-skia
lgtm
4 years, 6 months ago (2016-06-06 20:08:38 UTC) #8
bungeman-chromium
lgtm
4 years, 6 months ago (2016-06-06 20:08:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041113002/20001
4 years, 6 months ago (2016-06-06 20:09:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 21:22:55 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 21:27:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b765188e433cb3fea3ce675553269d8b660b8053
Cr-Commit-Position: refs/heads/master@{#398129}

Powered by Google App Engine
This is Rietveld 408576698