Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2041103007: [es6] Fix prototype chain walk for instanceof. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix prototype chain walk for instanceof. When walking up the prototype chain during OrdinaryHasInstance, we first check if the current prototype equals the expected one, and only afterwards check the current prototype against null. That's obviously wrong if we check something like Proxy, whose prototype is null. R=yangguo@chromium.org BUG=v8:5085 Committed: https://crrev.com/eb1c9e2723d1d371699c6251aa56fd52535927a6 Cr-Commit-Position: refs/heads/master@{#36840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-5085.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-09 05:53:45 UTC) #1
Benedikt Meurer
Hey Yang, Quickfix for ({}) instanceof Proxy. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-09 05:55:52 UTC) #2
Yang
lgtm.
4 years, 6 months ago (2016-06-09 05:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041103007/1
4 years, 6 months ago (2016-06-09 05:58:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 06:22:15 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 06:26:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb1c9e2723d1d371699c6251aa56fd52535927a6
Cr-Commit-Position: refs/heads/master@{#36840}

Powered by Google App Engine
This is Rietveld 408576698