Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2041103005: Cache packageName to base Uri mapping. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/package_config@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache packageName to base Uri mapping. This makes analysis with using incremental analysis cache 30% faster. Without this change getBase() takes 40% (!) of total analysis time. With this change - just 0.79% of total time. Although the remaining 17% of PackagesBase.resolve() make my cry. Why URI manipulations are SO SLOW?! R=brianwilkerson@google.com, pquitslund@google.com, kevmoo@google.com BUG= Committed: 71ec48333eb8785969a20903903585a39f29c9d7

Patch Set 1 #

Patch Set 2 : Prepare for publishing. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 1 comment Download
M lib/src/packages_io_impl.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 6 months ago (2016-06-07 20:10:35 UTC) #1
pquitslund
LGTM. Wow. Great catch!
4 years, 6 months ago (2016-06-07 20:41:47 UTC) #2
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-07 20:51:00 UTC) #3
kevmoo
One nit – otherwise...uh...awesome! https://codereview.chromium.org/2041103005/diff/20001/.gitignore File .gitignore (right): https://codereview.chromium.org/2041103005/diff/20001/.gitignore#newcode1 .gitignore:1: .idea Let's not ignore IDE-specific ...
4 years, 6 months ago (2016-06-07 22:49:12 UTC) #4
scheglov
4 years, 6 months ago (2016-06-08 01:50:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
71ec48333eb8785969a20903903585a39f29c9d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698