Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2041083002: MD Settings: Workaround for section expand/collapse animation jank. (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Workaround for section expand/collapse animation jank. Temporary workaround for crbug.com/617287 by using margin instead of padding. The result is not 100% identical but is very close. The transition bug this fixes is the jump right (and left) at the start (and end) of the subpage open animations. BUG=589681, 617287 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2559d25930929daaa397b783b86633163169805e Cr-Commit-Position: refs/heads/master@{#398981}

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : fix scroll position #

Total comments: 4

Patch Set 4 : bug # #

Patch Set 5 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page_css.html View 1 2 3 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
michaelpg
PTAL.
4 years, 6 months ago (2016-06-06 18:23:40 UTC) #2
dschuyler
On 2016/06/06 18:23:40, michaelpg wrote: > PTAL. I tried this out. It breaks the alignment ...
4 years, 6 months ago (2016-06-07 00:08:58 UTC) #4
michaelpg
PTAL, afaict this is pixel-perfect now. I couldn't find a pure-CSS way to do this. ...
4 years, 6 months ago (2016-06-07 18:15:28 UTC) #5
dschuyler
It's not that the hack fixes LGTM but the animation jank is worse than the ...
4 years, 6 months ago (2016-06-08 01:04:41 UTC) #6
michaelpg
https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resources/settings/settings_page_css.html File chrome/browser/resources/settings/settings_page_css.html (right): https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resources/settings/settings_page_css.html#newcode36 chrome/browser/resources/settings/settings_page_css.html:36: * 3px. */ On 2016/06/08 01:04:41, dschuyler wrote: > ...
4 years, 6 months ago (2016-06-09 18:31:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041083002/80001
4 years, 6 months ago (2016-06-09 18:33:24 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-09 19:29:52 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:31:15 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2559d25930929daaa397b783b86633163169805e
Cr-Commit-Position: refs/heads/master@{#398981}

Powered by Google App Engine
This is Rietveld 408576698