MD Settings: Workaround for section expand/collapse animation jank.

MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2559d25930929daaa397b783b86633163169805e
Cr-Commit-Position: refs/heads/master@{#398981}

[michaelpg, 2016-06-06 18:22:07]

Description was changed from

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681
R=dschuyler@chromium.org
==========

to

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-06-06 18:23:40]

PTAL.

[michaelpg, 2016-06-06 18:23:59]

Description was changed from

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-06-07 00:08:58]

On 2016/06/06 18:23:40, michaelpg wrote:
> PTAL.

I tried this out. It breaks the alignment Alan
asked for. On a build that has a working 
scroll-to-selection from the side nav, try
getting the section label (such as Appearance)
to line up with the top element in the side nav
(such as Basic or People -- depending on what
code you have).

The thing to avoid (even more than the alignment
mentioned above) is having the section title 
pressed up close the shadow of the top (blue)
bar.

[michaelpg, 2016-06-07 18:15:28]

PTAL, afaict this is pixel-perfect now. I couldn't find a pure-CSS way to do
this. Hopefully the blink issue is resolved soon.

[dschuyler, 2016-06-08 01:04:41]

It's not that the hack fixes LGTM
but the animation jank is worse than
the hacks :)
Thanks for finding a workaround.
(LGTM).

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page_css.html (right):

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page_css.html:36: * 3px. */
Let's include the bug number at 
each point of change, so that 
when the bug is eventually fixed
we can grep and find all of them.
e.g.
/* TODO(michaelpg): This is offset because of the previous addition of
 * 3px. crbug.com/617287. */

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page_css.html:42: * replacement of
margin with padding, above. */
 * replacement of margin with padding, above. crbug.com/617287. */

[michaelpg, 2016-06-09 18:31:19]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-06-09 18:31:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2041083002/#ps80001
(title: "rebase?")

[michaelpg, 2016-06-09 18:31:30]

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page_css.html (right):

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page_css.html:36: * 3px. */
On 2016/06/08 01:04:41, dschuyler wrote:
> Let's include the bug number at 
> each point of change, so that 
> when the bug is eventually fixed
> we can grep and find all of them.
> e.g.
> /* TODO(michaelpg): This is offset because of the previous addition of
>  * 3px. crbug.com/617287. */

Done.

https://codereview.chromium.org/2041083002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page_css.html:42: * replacement of
margin with padding, above. */
On 2016/06/08 01:04:41, dschuyler wrote:
>  * replacement of margin with padding, above. crbug.com/617287. */

Done.

[commit-bot: I haz the power, 2016-06-09 18:33:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041083002/80001

[commit-bot: I haz the power, 2016-06-09 19:29:52]

Description was changed from

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-09 19:29:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-09 19:31:14]

Description was changed from

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Workaround for section expand/collapse animation jank.

Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.

The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.

BUG=589681, 617287
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2559d25930929daaa397b783b86633163169805e
Cr-Commit-Position: refs/heads/master@{#398981}
==========

[commit-bot: I haz the power, 2016-06-09 19:31:15]

Patchset 5 (id:??) landed as
https://crrev.com/2559d25930929daaa397b783b86633163169805e
Cr-Commit-Position: refs/heads/master@{#398981}