Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2041073002: MD Settings: Responsive sub-page width (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Responsive sub-page width The width only needs to be set explicitly during animations, when the card is position: fixed. BUG=608134 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d9d220fa3bf6fad9443d84e4e53ddded5597f96e Cr-Commit-Position: refs/heads/master@{#398217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
4 years, 6 months ago (2016-06-06 18:02:51 UTC) #2
Dan Beam
lgtm would be cool if there was a test
4 years, 6 months ago (2016-06-07 00:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041073002/1
4 years, 6 months ago (2016-06-07 02:33:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 03:44:55 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 03:46:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d220fa3bf6fad9443d84e4e53ddded5597f96e
Cr-Commit-Position: refs/heads/master@{#398217}

Powered by Google App Engine
This is Rietveld 408576698