Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2041053002: Revert of Re-enable WebGL Image Chromium. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, f(malita), jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, dshwang, blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp64_webgl_deschedule
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable WebGL Image Chromium. (patchset #3 id:40001 of https://codereview.chromium.org/2025973002/ ) Reason for revert: I'm observing a behavior difference between the Image CHROMIUM and non-Image CHROMIUM path. Turning off Image CHROMIUM while I investigate. https://bugs.chromium.org/p/chromium/issues/detail?id=617249#c5 Original issue's description: > Re-enable WebGL Image Chromium. > > This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM, > and turns on IOSurface backed WebGL by default. > > BUG=581777 > > Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86 > Cr-Commit-Position: refs/heads/master@{#397603} TBR=kbr@chromium.org,avi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581777 Committed: https://crrev.com/6a90cbb5bebd484ea02e8fbd4894655092e0cf95 Cr-Commit-Position: refs/heads/master@{#398096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/child/runtime_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
erikchen
Created Revert of Re-enable WebGL Image Chromium.
4 years, 6 months ago (2016-06-06 17:29:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041053002/1
4 years, 6 months ago (2016-06-06 17:35:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:41:01 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:44:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a90cbb5bebd484ea02e8fbd4894655092e0cf95
Cr-Commit-Position: refs/heads/master@{#398096}

Powered by Google App Engine
This is Rietveld 408576698