Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: gpu/ipc/client/command_buffer_proxy_impl.h

Issue 2041043002: CommandBufferProxyImpl holds on to GpuMemoryBuffers while they are in use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/ipc/client/command_buffer_proxy_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/client/command_buffer_proxy_impl.h
diff --git a/gpu/ipc/client/command_buffer_proxy_impl.h b/gpu/ipc/client/command_buffer_proxy_impl.h
index aa47fe30122cd868f30da7916e2b74f374fd7add..757662bcec8674aaf1dd9e69995fbbf07c6f73d4 100644
--- a/gpu/ipc/client/command_buffer_proxy_impl.h
+++ b/gpu/ipc/client/command_buffer_proxy_impl.h
@@ -299,6 +299,11 @@ class GPU_EXPORT CommandBufferProxyImpl
// A map from image id to GpuMemoryBuffer id.
std::map<int32_t, int32_t> image_gmb_ids_map_;
+ // A map of GpuMemoryBuffers owned by this class (created from
+ // CreateGpuMemoryBufferImage). Unfortunatley, this cannot be combined with
+ // |image_gmb_ids_map_| since that container does not imply ownership.
piman 2016/06/06 19:28:52 nit: would it be possible to combine both maps, by
erikchen 2016/06/06 21:55:54 I created the ImageInfo struct as you suggested.
+ std::map<int32_t, std::unique_ptr<gfx::GpuMemoryBuffer>> image_gmb_map_;
+
base::WeakPtr<CommandBufferProxyImpl> weak_this_;
scoped_refptr<base::SequencedTaskRunner> callback_thread_;
« no previous file with comments | « no previous file | gpu/ipc/client/command_buffer_proxy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698