Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Issue 204103008: ArrayPop builtin handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing review notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -26 lines) Patch
M src/builtins.cc View 1 3 chunks +63 lines, -26 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-19 14:15:41 UTC) #1
Yang
LGTM. https://codereview.chromium.org/204103008/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/204103008/diff/1/src/builtins.cc#newcode566 src/builtins.cc:566: Handle<Object> maybe_elms = name is confusing. It's not ...
6 years, 9 months ago (2014-03-19 15:06:29 UTC) #2
Yang
On 2014/03/19 15:06:29, Yang wrote: > LGTM. > > https://codereview.chromium.org/204103008/diff/1/src/builtins.cc > File src/builtins.cc (right): > ...
6 years, 9 months ago (2014-03-19 15:06:42 UTC) #3
Igor Sheludko
6 years, 9 months ago (2014-03-19 15:25:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698