Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2041003003: Moved vr_service.mojom from blink to device (Closed)

Created:
4 years, 6 months ago by bajones
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved vr_service.mojom from blink to device BUG=612342 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03 Cr-Commit-Position: refs/heads/master@{#398439}

Patch Set 1 #

Patch Set 2 : Missed a dependency for the unit tests #

Patch Set 3 : Fixed conflict #

Patch Set 4 : Removed old dependecies from gyp files #

Patch Set 5 : Fixed missing mojo dependency in gyp builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -149 lines) Patch
M content/browser/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M device/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/vr/android/cardboard/cardboard_vr_device.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M device/vr/test/fake_vr_device.h View 1 chunk +6 lines, -6 lines 0 comments Download
M device/vr/test/fake_vr_device.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A device/vr/vr.gyp View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
M device/vr/vr_device.h View 2 chunks +3 lines, -3 lines 0 comments Download
M device/vr/vr_device_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M device/vr/vr_device_manager.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M device/vr/vr_device_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + device/vr/vr_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/vr/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VREyeParameters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRStageParameters.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRStageParameters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/modules/vr/OWNERS View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/public/platform/modules/vr/vr_service.mojom View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
bajones
rockot@: /device review, please? sievers@: /content review, please? mkwst@: blink review, please?
4 years, 6 months ago (2016-06-06 21:31:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041003003/20001
4 years, 6 months ago (2016-06-06 21:47:40 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/16851) ios-device-gn on ...
4 years, 6 months ago (2016-06-06 21:50:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041003003/40001
4 years, 6 months ago (2016-06-06 22:05:35 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/211966) linux_chromium_chromeos_rel_ng on ...
4 years, 6 months ago (2016-06-06 22:30:12 UTC) #11
jam
lgtm
4 years, 6 months ago (2016-06-06 22:54:08 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041003003/60001
4 years, 6 months ago (2016-06-06 23:20:24 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/212021) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 6 months ago (2016-06-06 23:37:50 UTC) #16
haraken
WebKit LGTM
4 years, 6 months ago (2016-06-07 00:04:17 UTC) #17
Mike West
LGTM 2.
4 years, 6 months ago (2016-06-07 05:37:01 UTC) #19
no sievers
content lgtm
4 years, 6 months ago (2016-06-07 18:25:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041003003/80001
4 years, 6 months ago (2016-06-07 20:02:35 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-08 00:42:46 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 00:45:17 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4ce365c1e195a8b28e632a890076a5c598875e03
Cr-Commit-Position: refs/heads/master@{#398439}

Powered by Google App Engine
This is Rietveld 408576698