Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2040983002: [asmjs] Validator should reject modules with repeated functions. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
Reviewers:
bradnelson, aseemgarg, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asmjs] Validator should reject modules with repeated functions. R=ahaas@chromium.org,aseemgarg@chromium.org,bradnelson@chromium.org BUG=chromium:617525 Committed: https://crrev.com/0b91952913e3e90e12e0c6908073dad51d43bf8e Cr-Commit-Position: refs/heads/master@{#36748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/typing-asm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-617525.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 6 months ago (2016-06-06 12:48:38 UTC) #1
ahaas
lgtm
4 years, 6 months ago (2016-06-06 13:28:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040983002/1
4 years, 6 months ago (2016-06-06 13:37:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 13:40:16 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 13:40:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b91952913e3e90e12e0c6908073dad51d43bf8e
Cr-Commit-Position: refs/heads/master@{#36748}

Powered by Google App Engine
This is Rietveld 408576698