Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2040963005: Update Symbol.hashCode (Closed)

Created:
4 years, 6 months ago by sra1
Modified:
4 years, 6 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update Symbol.hashCode New dart2js version avoids inefficient String.hashCode TBR=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6e6cc26efa35c3151f2d2c36994c00c2425510bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +5 lines, -1 line 0 comments Download
M tool/input_sdk/lib/internal/symbol.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tool/input_sdk/patch/internal_patch.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
sra1
Committed patchset #1 (id:1) manually as 6e6cc26efa35c3151f2d2c36994c00c2425510bf (presubmit successful).
4 years, 6 months ago (2016-06-06 19:35:11 UTC) #4
Leaf
4 years, 6 months ago (2016-06-06 22:40:44 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698