Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2040963002: Get the correct number of pages to paint a fixed object on. (Closed)

Created:
4 years, 6 months ago by rhogan
Modified:
4 years, 6 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, mstensho (USE GERRIT), slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get the correct number of pages to paint a fixed object on. Fix off-by-one error in https://crrev.com/385513 BUG=617553 Committed: https://crrev.com/dc00125736adfcaf8e36f6a6418880c5536bf590 Cr-Commit-Position: refs/heads/master@{#398090}

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/printing/fixed-positioned-child-shouldnt-print.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/fixed-positioned-child-shouldnt-print-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rhogan
4 years, 6 months ago (2016-06-06 10:59:33 UTC) #2
Xianzhu
lgtm
4 years, 6 months ago (2016-06-06 18:08:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040963002/20001
4 years, 6 months ago (2016-06-06 18:09:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 19:26:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:28:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc00125736adfcaf8e36f6a6418880c5536bf590
Cr-Commit-Position: refs/heads/master@{#398090}

Powered by Google App Engine
This is Rietveld 408576698