Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2040953002: [rng] improve RNG seed. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[rng] improve RNG seed. Prior to this change, both 0 and 1 as RNG seed would result in the same internal state. state0 and state1 cannot both be zero, but murmur hash maps 0 back to 0. R=cbruni@chromium.org BUG=v8:5069 Committed: https://crrev.com/d75baead74452c92d80065c3c5c7d5171670e120 Cr-Commit-Position: refs/heads/master@{#36757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/base/utils/random-number-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
4 years, 6 months ago (2016-06-06 10:54:25 UTC) #1
Camillo Bruni
Personally it felt safer to just flip one bit in case of a 0 hash ...
4 years, 6 months ago (2016-06-06 12:41:53 UTC) #2
Yang
On 2016/06/06 12:41:53, Camillo Bruni wrote: > Personally it felt safer to just flip one ...
4 years, 6 months ago (2016-06-06 12:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040953002/1
4 years, 6 months ago (2016-06-06 12:49:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-06 14:50:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040953002/1
4 years, 6 months ago (2016-06-06 14:50:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 15:01:22 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:02:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d75baead74452c92d80065c3c5c7d5171670e120
Cr-Commit-Position: refs/heads/master@{#36757}

Powered by Google App Engine
This is Rietveld 408576698