Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2040933002: [Clean-up] Remove unused codes (Closed)

Created:
4 years, 6 months ago by Jimmy Jo
Modified:
4 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Clean-up] Remove unused codes It doesn't look like this code is used and besides AutofillExternalDelegate::has_shown_popup_for_current_edit_ looks like same variable. Committed: https://crrev.com/1aa09c31c83bf27b2579467e597ca4aa7d20e795 Cr-Commit-Position: refs/heads/master@{#398018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Jimmy Jo
PTAL!
4 years, 6 months ago (2016-06-06 10:05:53 UTC) #3
vabr (Chromium)
Nice clean-up, LGTM! Vaclav
4 years, 6 months ago (2016-06-06 12:53:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040933002/1
4 years, 6 months ago (2016-06-06 13:05:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 13:53:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1aa09c31c83bf27b2579467e597ca4aa7d20e795 Cr-Commit-Position: refs/heads/master@{#398018}
4 years, 6 months ago (2016-06-06 13:54:19 UTC) #10
Jimmy Jo
4 years, 6 months ago (2016-06-07 00:46:11 UTC) #11
Message was sent while issue was closed.
On 2016/06/06 13:54:19, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/1aa09c31c83bf27b2579467e597ca4aa7d20e795
> Cr-Commit-Position: refs/heads/master@{#398018}

Thanks for review.

Powered by Google App Engine
This is Rietveld 408576698