chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html - Issue 2040883002: [Media Router] Assign each route a current cast mode if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 2040883002: [Media Router] Assign each route a current cast mode if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('j') | chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

index 33522e69cb972ce56e754d2667fa921f02fb311a..447dcc2fb853d3497d0139a6b8851baced245da7 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

@@ -86,7 +86,7 @@

if="[[!computeRouteDetailsHidden_(currentView_, issue)]]">

<route-details id="route-details" route="[[currentRoute_]]"

available-cast-modes="[[computeAvailableCastModesForRoute_(currentRoute_)]]"

- replace-route-available="[[!currentLaunchingSinkId_]]"

+ replace-route-available="[[computeReplaceRouteAvailable_(currentRoute_, currentLaunchingSinkId_, shownCastModeValue_)]]"

apacible 2016/06/06 20:17:10 nit: Can you split this into two lines? With a rec

btolsch 2016/06/06 23:46:52 Nice! The line is gone now though.

on-close-route="onCloseRoute_"

on-replace-route-click="onReplaceRouteClick_">

</route-details>