Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2040853003: Add a convenience method to get the debugged context (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a convenience method to get the debugged context Since the generic GetCallingContext is deprecated, but there's still the use case for the debugger to get the currently debugged context while in the debug context, add a convenience API for it. Note that EventDetails already exposes this context, but the embedder might not necessarily have the EventDetails around. R=verwaest@chromium.org BUG= Committed: https://crrev.com/37394eb3b0b7d38bccedef268aed4bb307db6ce7 Cr-Commit-Position: refs/heads/master@{#36751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M include/v8-debug.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/debug/debug.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-06-06 13:38:37 UTC) #1
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-06 13:54:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040853003/1
4 years, 6 months ago (2016-06-06 13:55:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 14:11:36 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 14:12:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37394eb3b0b7d38bccedef268aed4bb307db6ce7
Cr-Commit-Position: refs/heads/master@{#36751}

Powered by Google App Engine
This is Rietveld 408576698