Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 2040853002: Changed CSSParser::parseFontFaceDescriptor to return a const CSSValue* (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@_fix_copy_locs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed CSSParser::parseFontFaceDescriptor to return a const CSSValue* Changed CSSParser::parseFontFaceDescriptor to return a const CSSValue*, which required changing FontFace to store Member<const CSSValue> instead of regular Member<CSSValue>. This is an entirely mechanical change and is pre-work for making StylePropertySet::getPropertyCSSValue return a const CSSValue*. BUG=526586 Committed: https://crrev.com/911993afed6ee62b350df6338ebf5f2e56cf3b59 Cr-Commit-Position: refs/heads/master@{#401215}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sashab
4 years, 6 months ago (2016-06-06 05:46:39 UTC) #2
sashab
This one too :) Thanks Rune
4 years, 6 months ago (2016-06-21 06:15:37 UTC) #5
rune
lgtm
4 years, 6 months ago (2016-06-21 07:23:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040853002/60001
4 years, 6 months ago (2016-06-22 05:15:45 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-22 06:26:03 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 06:28:34 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/911993afed6ee62b350df6338ebf5f2e56cf3b59
Cr-Commit-Position: refs/heads/master@{#401215}

Powered by Google App Engine
This is Rietveld 408576698