Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2040813005: [snapshot] remove metadata field. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] remove metadata field. The upcoming snapshot creator API will have no way to distinguish default from custom snapshots. R=vogelheim@chromium.org BUG=chromium:617892 Committed: https://crrev.com/31c0c024bb73e2d7ac3f66d70d9450beaef39c2e Cr-Commit-Position: refs/heads/master@{#36812}

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 1

Patch Set 3 : addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -70 lines) Patch
M include/v8.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 5 chunks +3 lines, -18 lines 0 comments Download
M src/snapshot/snapshot.h View 3 chunks +4 lines, -22 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 7 chunks +3 lines, -26 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 6 months ago (2016-06-07 08:57:38 UTC) #1
vogelheim
lgtm Thanks for the ahead-of-time explanation; I wouldn't have understood the CL without. :-) https://codereview.chromium.org/2040813005/diff/20001/include/v8.h ...
4 years, 6 months ago (2016-06-07 13:27:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040813005/40001
4 years, 6 months ago (2016-06-08 07:20:12 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 07:48:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 07:51:42 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31c0c024bb73e2d7ac3f66d70d9450beaef39c2e
Cr-Commit-Position: refs/heads/master@{#36812}

Powered by Google App Engine
This is Rietveld 408576698