Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2040813004: Add BlimpContents[,Observer] and BlimpNavigationController (Closed)

Created:
4 years, 6 months ago by nyquist
Modified:
4 years, 6 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, shaktisahu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BlimpContents[,Observer] and BlimpNavigationController This CL adds the public API for //blimp/client/core and adds a simple implementation with a test for the core functionality. The setup of BlimpContents and related classes is intentionally similar to how the //content API is organized. Users of this API are supposed to depend on the code in //blimp/client/core/public, and not the implementation which lives in //blimp/client/core directly. BUG=611103 Committed: https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e Cr-Commit-Position: refs/heads/master@{#400456}

Patch Set 1 #

Patch Set 2 : Removed GetURL from BlimpContents and made navigation controller a reference - merged origin/master #

Patch Set 3 : Fix impl for BlimpContents' reference of nav controller #

Patch Set 4 : git merge origin/master #

Patch Set 5 : add comments and remove unnecessary includes #

Patch Set 6 : added visibility and cleaned up some more #

Patch Set 7 : git merge origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -3 lines) Patch
M blimp/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A blimp/client/core/BUILD.gn View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_contents_impl.h View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_contents_impl.cc View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_contents_impl_unittest.cc View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_navigation_controller_delegate.h View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_navigation_controller_impl.h View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_navigation_controller_impl.cc View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A blimp/client/core/blimp_navigation_controller_impl_unittest.cc View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
A + blimp/client/core/public/BUILD.gn View 1 2 3 4 5 6 1 chunk +6 lines, -3 lines 0 comments Download
A blimp/client/core/public/blimp_contents.h View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A blimp/client/core/public/blimp_contents_observer.h View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
A blimp/client/core/public/blimp_navigation_controller.h View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040813004/40001
4 years, 6 months ago (2016-06-10 01:37:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/79591) android_clang_dbg_recipe on ...
4 years, 6 months ago (2016-06-10 01:43:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040813004/100001
4 years, 6 months ago (2016-06-10 23:44:00 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245198)
4 years, 6 months ago (2016-06-11 01:03:57 UTC) #10
nyquist
dtrainor: PTAL
4 years, 6 months ago (2016-06-11 02:07:53 UTC) #12
David Trainor- moved to gerrit
lgtm!
4 years, 6 months ago (2016-06-16 22:43:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040813004/100001
4 years, 6 months ago (2016-06-17 00:34:46 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/22401) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-17 00:38:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040813004/120001
4 years, 6 months ago (2016-06-17 17:03:00 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-17 18:07:31 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 18:08:50 UTC) #24
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e
Cr-Commit-Position: refs/heads/master@{#400456}

Powered by Google App Engine
This is Rietveld 408576698