Issue 2040813003: Fix history page middle click action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2040813003: Fix history page middle click action (Closed)

Created:
4 years, 6 months ago by dtapuska

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Fix history page middle click action Send synthetic middle click in history page and also prevent default it as the links in history page will trigger twice if we don't prevent default it. BUG=609020 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2018943003 Cr-Commit-Position: refs/heads/master@{#397512} (cherry picked from commit a154aed1a3813cf28c6f477579ed7974a2528570) Committed: https://chromium.googlesource.com/chromium/src/+/20cd211911527a6aa2c20486738a9870a0b40824

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -25 lines)			Patch
M	chrome/browser/resources/history/history.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/ntp4/synthetic_middleclick.js	View	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/resources/synthetic_middleclick.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

dtapuska

4 years, 6 months ago (2016-06-06 18:34:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
20cd211911527a6aa2c20486738a9870a0b40824.