Issue 20408: Experimental: more stuff to get ARM to work. Stubbed out frame merge...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20408: Experimental: more stuff to get ARM to work. Stubbed out frame merge... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: more stuff to get ARM to work. Stubbed out frame merge code (frames are always spilled on ARM). Threaded frame to deferred code. Renamed some functions for uniformity. Committed: http://code.google.com/p/v8/source/detail?r=1283

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+387 lines, -211 lines)			Patch
M	src/codegen-arm.cc	View	26 chunks	+244 lines, -145 lines	2 comments	Download
M	src/codegen-ia32.cc	View	21 chunks	+56 lines, -56 lines	0 comments	Download
M	src/virtual-frame-arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/virtual-frame-arm.cc	View	4 chunks	+86 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/20408/diff/1/2 File src/codegen-arm.cc (right): http://codereview.chromium.org/20408/diff/1/2#newcode731 Line 731: __ mov(r1, Operand(Smi::FromInt(value_))); // x This comment ...

11 years, 10 months ago (2009-02-17 08:01:19 UTC) #2

Kevin Millikin (Chromium)

11 years, 10 months ago (2009-02-17 08:08:44 UTC) #3

http://codereview.chromium.org/20408/diff/1/2
File src/codegen-arm.cc (right):

http://codereview.chromium.org/20408/diff/1/2#newcode731
Line 731: __ mov(r1, Operand(Smi::FromInt(value_)));  // x
On 2009/02/17 08:01:20, Mads Ager wrote:
> This comment seems old and out of context here.  Remove it?

Done.

Expand Messages | Collapse Messages