Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2040783002: Drop unnecessary override of OnWindowBoundsChanged in NativeWidgetMus::MusWindowObserver (Closed)

Created:
4 years, 6 months ago by Mark Dittmer
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unnecessary override of OnWindowBoundsChanged in NativeWidgetMus::MusWindowObserver R=sky@chromium.org BUG=617315 Committed: https://crrev.com/72925754efce72c58d353db9d7c2b85855e6dcb7 Cr-Commit-Position: refs/heads/master@{#398125}

Patch Set 1 #

Patch Set 2 : Set delegate in StubWindow to enable normal flow for notifying OnBoundsChanged #

Total comments: 1

Patch Set 3 : Include base/logging.h for DCHECK #

Patch Set 4 : Add build deps for base #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M ui/platform_window/stub/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/stub/stub_window.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/platform_window/stub/stub_window.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M ui/platform_window/stub/stub_window.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 36 (15 generated)
Mark Dittmer
4 years, 6 months ago (2016-06-05 18:14:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/1
4 years, 6 months ago (2016-06-05 18:15:13 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/158978)
4 years, 6 months ago (2016-06-05 19:02:40 UTC) #5
Mark Dittmer
Set delegate in StubWindow to enable normal flow for notifying OnBoundsChanged
4 years, 6 months ago (2016-06-06 14:57:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/20001
4 years, 6 months ago (2016-06-06 14:57:43 UTC) #8
Mark Dittmer
sky@chromium.org: PTAL: Enabled use of delegate for mus + StubWindow case with optional StubWindow ctor ...
4 years, 6 months ago (2016-06-06 14:59:34 UTC) #9
Mark Dittmer
Include base/logging.h for DCHECK
4 years, 6 months ago (2016-06-06 15:21:30 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/40001
4 years, 6 months ago (2016-06-06 15:21:57 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/211699)
4 years, 6 months ago (2016-06-06 16:05:17 UTC) #14
Mark Dittmer
Add build deps for base
4 years, 6 months ago (2016-06-06 16:31:05 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/60001
4 years, 6 months ago (2016-06-06 16:31:58 UTC) #17
sky
LGTM https://codereview.chromium.org/2040783002/diff/20001/ui/platform_window/stub/stub_window.h File ui/platform_window/stub/stub_window.h (right): https://codereview.chromium.org/2040783002/diff/20001/ui/platform_window/stub/stub_window.h#newcode19 ui/platform_window/stub/stub_window.h:19: bool use_default_accelerated_widget = true); It isn't obvious what ...
4 years, 6 months ago (2016-06-06 16:35:26 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 17:58:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/60001
4 years, 6 months ago (2016-06-06 18:21:40 UTC) #22
commit-bot: I haz the power
Failed to apply patch for ui/views/mus/window_tree_host_mus.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-06 18:28:05 UTC) #24
Mark Dittmer
rebase
4 years, 6 months ago (2016-06-06 18:35:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/80001
4 years, 6 months ago (2016-06-06 18:36:25 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/224027)
4 years, 6 months ago (2016-06-06 19:08:22 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040783002/80001
4 years, 6 months ago (2016-06-06 19:56:44 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-06 21:18:55 UTC) #34
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 21:20:13 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/72925754efce72c58d353db9d7c2b85855e6dcb7
Cr-Commit-Position: refs/heads/master@{#398125}

Powered by Google App Engine
This is Rietveld 408576698