Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2040693002: Rename RootScroller class to RootScrollerController. (Closed)

Created:
4 years, 6 months ago by bokan
Modified:
4 years, 6 months ago
Reviewers:
tdresser
CC:
chromium-reviews, kenneth.christiansen, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename RootScroller class to RootScrollerController. Its weird that the rootScroller property on document takes an Element but the RootScroller object is really a manager class. Rename it to make this more clear and prevent confusion. BUG=505516 Committed: https://crrev.com/c63b2d9e1a84d24421adca8a65b52cb12da1d8c9 Cr-Commit-Position: refs/heads/master@{#398048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -302 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/RootScroller.h View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/RootScroller.cpp View 1 chunk +0 lines, -165 lines 0 comments Download
A + third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h View 4 chunks +12 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bokan
4 years, 6 months ago (2016-06-06 12:25:48 UTC) #3
tdresser
LGTM. I'm unsure whether "Controller" or "Manager" would be better here, but either is fine ...
4 years, 6 months ago (2016-06-06 14:51:40 UTC) #4
bokan
I'm also on the fence but in https://chromium.googlesource.com/chromium/src.git/+/16c5f9e182d412046291088ab782579f315bf100 Elliott suggested Controller so I just went ...
4 years, 6 months ago (2016-06-06 14:52:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040693002/1
4 years, 6 months ago (2016-06-06 14:52:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 16:48:10 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:50:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c63b2d9e1a84d24421adca8a65b52cb12da1d8c9
Cr-Commit-Position: refs/heads/master@{#398048}

Powered by Google App Engine
This is Rietveld 408576698