src/api.cc - Issue 2040683002: Remove dependencies of V8 on cpu-profiler is_profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2040683002: Remove dependencies of V8 on cpu-profiler is_profiling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: use macro for declaring is_profiling Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index c9abd23cdb0517861bc9720cf888f78bcdf4940b..2679a363f7fc0c0b8227348378e471cfbdd75f0f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -8287,8 +8287,8 @@ CpuProfile* CpuProfiler::StopProfiling(Local<String> title) {

void CpuProfiler::SetIdle(bool is_idle) {

i::CpuProfiler* profiler = reinterpret_cast<i::CpuProfiler*>(this);

- if (!profiler->is_profiling()) return;

i::Isolate* isolate = profiler->isolate();

+ if (!isolate->is_profiling()) return;

v8::StateTag state = isolate->current_vm_state();

DCHECK(state == v8::EXTERNAL || state == v8::IDLE);

if (isolate->js_entry_sp() != NULL) return;

« no previous file with comments | « no previous file | src/assembler.cc » ('j') | no next file with comments »