Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: test/cctest/test-api.h

Issue 2040683002: Remove dependencies of V8 on cpu-profiler is_profiling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: use macro for declaring is_profiling Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/snapshot/code-serializer.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/isolate.h" 7 #include "src/isolate.h"
8 #include "src/profiler/cpu-profiler.h"
9 #include "src/vm-state.h" 8 #include "src/vm-state.h"
10 #include "test/cctest/cctest.h" 9 #include "test/cctest/cctest.h"
11 10
12 template <typename T> 11 template <typename T>
13 static void CheckReturnValue(const T& t, i::Address callback) { 12 static void CheckReturnValue(const T& t, i::Address callback) {
14 v8::ReturnValue<v8::Value> rv = t.GetReturnValue(); 13 v8::ReturnValue<v8::Value> rv = t.GetReturnValue();
15 i::Object** o = *reinterpret_cast<i::Object***>(&rv); 14 i::Object** o = *reinterpret_cast<i::Object***>(&rv);
16 CHECK_EQ(CcTest::isolate(), t.GetIsolate()); 15 CHECK_EQ(CcTest::isolate(), t.GetIsolate());
17 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(t.GetIsolate()); 16 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(t.GetIsolate());
18 CHECK_EQ(t.GetIsolate(), rv.GetIsolate()); 17 CHECK_EQ(t.GetIsolate(), rv.GetIsolate());
19 CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate)); 18 CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate));
20 // Verify reset 19 // Verify reset
21 bool is_runtime = (*o)->IsTheHole(isolate); 20 bool is_runtime = (*o)->IsTheHole(isolate);
22 if (is_runtime) { 21 if (is_runtime) {
23 CHECK(rv.Get()->IsUndefined()); 22 CHECK(rv.Get()->IsUndefined());
24 } else { 23 } else {
25 i::Handle<i::Object> v = v8::Utils::OpenHandle(*rv.Get()); 24 i::Handle<i::Object> v = v8::Utils::OpenHandle(*rv.Get());
26 CHECK_EQ(*v, *o); 25 CHECK_EQ(*v, *o);
27 } 26 }
28 rv.Set(true); 27 rv.Set(true);
29 CHECK(!(*o)->IsTheHole(isolate) && !(*o)->IsUndefined(isolate)); 28 CHECK(!(*o)->IsTheHole(isolate) && !(*o)->IsUndefined(isolate));
30 rv.Set(v8::Local<v8::Object>()); 29 rv.Set(v8::Local<v8::Object>());
31 CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate)); 30 CHECK((*o)->IsTheHole(isolate) || (*o)->IsUndefined(isolate));
32 CHECK_EQ(is_runtime, (*o)->IsTheHole()); 31 CHECK_EQ(is_runtime, (*o)->IsTheHole());
33 // If CPU profiler is active check that when API callback is invoked 32 // If CPU profiler is active check that when API callback is invoked
34 // VMState is set to EXTERNAL. 33 // VMState is set to EXTERNAL.
35 if (isolate->cpu_profiler()->is_profiling()) { 34 if (isolate->is_profiling()) {
36 CHECK_EQ(v8::EXTERNAL, isolate->current_vm_state()); 35 CHECK_EQ(v8::EXTERNAL, isolate->current_vm_state());
37 CHECK(isolate->external_callback_scope()); 36 CHECK(isolate->external_callback_scope());
38 CHECK_EQ(callback, isolate->external_callback_scope()->callback()); 37 CHECK_EQ(callback, isolate->external_callback_scope()->callback());
39 } 38 }
40 } 39 }
OLDNEW
« no previous file with comments | « src/snapshot/code-serializer.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698