Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: src/compiler.cc

Issue 2040683002: Remove dependencies of V8 on cpu-profiler is_profiling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: use macro for declaring is_profiling Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler.h" 5 #include "src/compiler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "src/ast/ast-numbering.h" 9 #include "src/ast/ast-numbering.h"
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 flags_(0), 128 flags_(0),
129 code_flags_(code_flags), 129 code_flags_(code_flags),
130 mode_(mode), 130 mode_(mode),
131 osr_ast_id_(BailoutId::None()), 131 osr_ast_id_(BailoutId::None()),
132 zone_(zone), 132 zone_(zone),
133 deferred_handles_(nullptr), 133 deferred_handles_(nullptr),
134 dependencies_(isolate, zone), 134 dependencies_(isolate, zone),
135 bailout_reason_(kNoReason), 135 bailout_reason_(kNoReason),
136 prologue_offset_(Code::kPrologueOffsetNotSet), 136 prologue_offset_(Code::kPrologueOffsetNotSet),
137 track_positions_(FLAG_hydrogen_track_positions || 137 track_positions_(FLAG_hydrogen_track_positions ||
138 isolate->cpu_profiler()->is_profiling()), 138 isolate->is_profiling()),
139 parameter_count_(0), 139 parameter_count_(0),
140 optimization_id_(-1), 140 optimization_id_(-1),
141 osr_expr_stack_height_(0), 141 osr_expr_stack_height_(0),
142 debug_name_(debug_name) {} 142 debug_name_(debug_name) {}
143 143
144 CompilationInfo::~CompilationInfo() { 144 CompilationInfo::~CompilationInfo() {
145 DisableFutureOptimization(); 145 DisableFutureOptimization();
146 dependencies()->Rollback(); 146 dependencies()->Rollback();
147 delete deferred_handles_; 147 delete deferred_handles_;
148 } 148 }
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 Script::cast(shared->script())->compilation_type() == 379 Script::cast(shared->script())->compilation_type() ==
380 Script::COMPILATION_TYPE_EVAL; 380 Script::COMPILATION_TYPE_EVAL;
381 } 381 }
382 382
383 void RecordFunctionCompilation(Logger::LogEventsAndTags tag, 383 void RecordFunctionCompilation(Logger::LogEventsAndTags tag,
384 CompilationInfo* info) { 384 CompilationInfo* info) {
385 // Log the code generation. If source information is available include 385 // Log the code generation. If source information is available include
386 // script name and line number. Check explicitly whether logging is 386 // script name and line number. Check explicitly whether logging is
387 // enabled as finding the line number is not free. 387 // enabled as finding the line number is not free.
388 if (info->isolate()->logger()->is_logging_code_events() || 388 if (info->isolate()->logger()->is_logging_code_events() ||
389 info->isolate()->cpu_profiler()->is_profiling()) { 389 info->isolate()->is_profiling()) {
390 Handle<SharedFunctionInfo> shared = info->shared_info(); 390 Handle<SharedFunctionInfo> shared = info->shared_info();
391 Handle<Script> script = info->parse_info()->script(); 391 Handle<Script> script = info->parse_info()->script();
392 Handle<AbstractCode> abstract_code = 392 Handle<AbstractCode> abstract_code =
393 info->has_bytecode_array() 393 info->has_bytecode_array()
394 ? Handle<AbstractCode>::cast(info->bytecode_array()) 394 ? Handle<AbstractCode>::cast(info->bytecode_array())
395 : Handle<AbstractCode>::cast(info->code()); 395 : Handle<AbstractCode>::cast(info->code());
396 if (abstract_code.is_identical_to( 396 if (abstract_code.is_identical_to(
397 info->isolate()->builtins()->CompileLazy())) { 397 info->isolate()->builtins()->CompileLazy())) {
398 return; 398 return;
399 } 399 }
(...skipping 1405 matching lines...) Expand 10 before | Expand all | Expand 10 after
1805 DCHECK(shared->is_compiled()); 1805 DCHECK(shared->is_compiled());
1806 function->set_literals(cached.literals); 1806 function->set_literals(cached.literals);
1807 } else if (shared->is_compiled()) { 1807 } else if (shared->is_compiled()) {
1808 // TODO(mvstanton): pass pretenure flag to EnsureLiterals. 1808 // TODO(mvstanton): pass pretenure flag to EnsureLiterals.
1809 JSFunction::EnsureLiterals(function); 1809 JSFunction::EnsureLiterals(function);
1810 } 1810 }
1811 } 1811 }
1812 1812
1813 } // namespace internal 1813 } // namespace internal
1814 } // namespace v8 1814 } // namespace v8
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698