Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2040673002: Resynthesize enum fields lazily. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -50 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 8 chunks +206 lines, -2 lines 2 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +0 lines, -47 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 6 months ago (2016-06-04 01:45:39 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2040673002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2040673002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1791 pkg/analyzer/lib/src/dart/element/element.dart:1791: * A value field of an enum. This ...
4 years, 6 months ago (2016-06-06 13:39:50 UTC) #2
scheglov
https://codereview.chromium.org/2040673002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2040673002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1791 pkg/analyzer/lib/src/dart/element/element.dart:1791: * A value field of an enum. On 2016/06/06 ...
4 years, 6 months ago (2016-06-06 15:31:43 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as df61e8d64a0c2c1a3b5bc399f53d3a6d371139b9 (presubmit successful).
4 years, 6 months ago (2016-06-06 15:32:09 UTC) #5
Paul Berry
4 years, 6 months ago (2016-06-06 15:47:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698