Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3474)

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 2040663002: Tracing: Added necessary plumbing to make sure clocksync metadata events are always included. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event.h ('k') | base/trace_event/trace_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_unittest.cc
diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc
index 25a6d5f3f6213508b9fcc838179038a597252ec1..b47524d3e86c44f01e859b381aa7f22d282b5cfb 100644
--- a/base/trace_event/trace_event_unittest.cc
+++ b/base/trace_event/trace_event_unittest.cc
@@ -1257,13 +1257,11 @@ TEST_F(TraceEventTestFixture, AddMetadataEvent) {
std::unique_ptr<ConvertableToTraceFormat> conv1(new Convertable(&num_calls));
std::unique_ptr<Convertable> conv2(new Convertable(&num_calls));
- BeginTrace();
- TRACE_EVENT_API_ADD_METADATA_EVENT(
- TraceLog::GetCategoryGroupEnabled("__metadata"), "metadata_event_1",
- "metadata_arg_name", std::move(conv1));
- TRACE_EVENT_API_ADD_METADATA_EVENT(
- TraceLog::GetCategoryGroupEnabled("__metadata"), "metadata_event_2",
- "metadata_arg_name", std::move(conv2));
+ BeginSpecificTrace("irrelevant_cat");
+ TRACE_EVENT_METADATA_FORCED1("metadata_event_1", "metadata_arg_name",
+ std::move(conv1));
+ TRACE_EVENT_METADATA_FORCED1("metadata_event_2", "metadata_arg_name",
+ std::move(conv2));
// |AppendAsTraceFormat| should only be called on flush, not when the event
// is added.
ASSERT_EQ(0, num_calls);
« no previous file with comments | « base/trace_event/trace_event.h ('k') | base/trace_event/trace_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698