Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.h

Issue 204063002: Oilpan: add transition types to Navigator and its supplements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/NavigatorServiceWorker.h
diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.h b/Source/modules/serviceworkers/NavigatorServiceWorker.h
index b1a2e4e49489a417a37c0c6a7883eacbbb27e4ef..023afd249b189795a8c3b9f268e91b00ebc55f96 100644
--- a/Source/modules/serviceworkers/NavigatorServiceWorker.h
+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.h
@@ -7,6 +7,7 @@
#include "bindings/v8/ScriptPromise.h"
#include "core/frame/Navigator.h"
+#include "heap/Handle.h"
#include "platform/Supplementable.h"
namespace WebCore {
@@ -14,15 +15,18 @@ namespace WebCore {
class Navigator;
class ServiceWorkerContainer;
-class NavigatorServiceWorker FINAL : public Supplement<Navigator>, DOMWindowProperty {
+class NavigatorServiceWorker FINAL : public NoBaseWillBeGarbageCollectedFinalized<NavigatorServiceWorker>, public WillBeHeapSupplement<Navigator>, DOMWindowProperty {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorServiceWorker);
public:
virtual ~NavigatorServiceWorker();
static NavigatorServiceWorker& from(Navigator&);
- static NavigatorServiceWorker* toNavigatorServiceWorker(Navigator& navigator) { return static_cast<NavigatorServiceWorker*>(Supplement<Navigator>::from(navigator, supplementName())); }
+ static NavigatorServiceWorker* toNavigatorServiceWorker(Navigator&);
static const char* supplementName();
static ServiceWorkerContainer* serviceWorker(ExecutionContext*, Navigator&);
+ virtual void trace(Visitor*) { }
haraken 2014/03/19 04:02:36 Drop virtual.
+
private:
explicit NavigatorServiceWorker(Navigator&);
ServiceWorkerContainer* serviceWorker(ExecutionContext*);

Powered by Google App Engine
This is Rietveld 408576698