Source/modules/donottrack/NavigatorDoNotTrack.cpp - Issue 204063002: Oilpan: add transition types to Navigator and its supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/donottrack/NavigatorDoNotTrack.cpp

Issue 204063002: Oilpan: add transition types to Navigator and its supplements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/donottrack/NavigatorDoNotTrack.h ('K') | « Source/modules/donottrack/NavigatorDoNotTrack.h ('k') | Source/modules/gamepad/NavigatorGamepad.h » ('j') | Source/modules/quota/NavigatorStorageQuota.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/donottrack/NavigatorDoNotTrack.cpp

diff --git a/Source/modules/donottrack/NavigatorDoNotTrack.cpp b/Source/modules/donottrack/NavigatorDoNotTrack.cpp

index aa56df717dc2e2b88242347c79487fe5cfdfe620..7589b3534549d2a104b9740b34afbeff972f1002 100644

--- a/Source/modules/donottrack/NavigatorDoNotTrack.cpp

+++ b/Source/modules/donottrack/NavigatorDoNotTrack.cpp

@@ -53,10 +53,10 @@ const char* NavigatorDoNotTrack::supplementName()

NavigatorDoNotTrack& NavigatorDoNotTrack::from(Navigator& navigator)

{

- NavigatorDoNotTrack* supplement = static_cast<NavigatorDoNotTrack*>(Supplement<Navigator>::from(navigator, supplementName()));

+ NavigatorDoNotTrack* supplement = static_cast<NavigatorDoNotTrack*>(WillBeHeapSupplement<Navigator>::from(navigator, supplementName()));

if (!supplement) {

supplement = new NavigatorDoNotTrack(navigator.frame());

- provideTo(navigator, supplementName(), adoptPtr(supplement));

+ provideTo(navigator, supplementName(), adoptPtrWillBeNoop(supplement));

}

return *supplement;

}