Issue 204063002: Oilpan: add transition types to Navigator and its supplements.

Issue 204063002: Oilpan: add transition types to Navigator and its supplements. (Closed)

Created:
6 years, 9 months ago by sof

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, nhiroki, arv+blink, tzik, serviceworker-reviews, jsbell+serviceworker_chromium.org, timvolodine, kinuko, mvanouwerkerk+watch_chromium.org, Inactive, falken, horo+watch_chromium.org, watchdog-blink-watchlist_google.com, alecflett+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: add transition types to Navigator and its supplements. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169529

Patch Set 1 #

Total comments: 6

Patch Set 2 : Adjust use of 'virtual' #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -39 lines)			Patch
M	Source/core/frame/DOMWindow.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/Navigator.h	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	Source/core/frame/Navigator.cpp	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/frame/Navigator.idl	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/modules/battery/BatteryManager.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/modules/battery/BatteryManager.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/battery/NavigatorBattery.h	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/modules/battery/NavigatorBattery.cpp	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	Source/modules/donottrack/NavigatorDoNotTrack.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	Source/modules/donottrack/NavigatorDoNotTrack.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/gamepad/NavigatorGamepad.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/modules/gamepad/NavigatorGamepad.cpp	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/modules/geolocation/NavigatorGeolocation.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/modules/geolocation/NavigatorGeolocation.cpp	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	Source/modules/quota/NavigatorStorageQuota.h	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
M	Source/modules/quota/NavigatorStorageQuota.cpp	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/NavigatorServiceWorker.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/NavigatorServiceWorker.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	Source/modules/webmidi/NavigatorWebMIDI.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	Source/modules/webmidi/NavigatorWebMIDI.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. Nothing unexpected or unusual encountered.

6 years, 9 months ago (2014-03-18 22:36:06 UTC) #1

haraken

LGTM https://codereview.chromium.org/204063002/diff/1/Source/modules/battery/NavigatorBattery.h File Source/modules/battery/NavigatorBattery.h (right): https://codereview.chromium.org/204063002/diff/1/Source/modules/battery/NavigatorBattery.h#newcode17 Source/modules/battery/NavigatorBattery.h:17: class NavigatorBattery : public NoBaseWillBeGarbageCollectedFinalized<NavigatorBattery>, public WillBeHeapSupplement<Navigator> { ...

6 years, 9 months ago (2014-03-19 04:02:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/204063002/20001

6 years, 9 months ago (2014-03-19 07:06:36 UTC) #5

Message was sent while issue was closed.

Change committed as 169529

Expand Messages | Collapse Messages