Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2040623003: Add standard Windows manifest to five v8 executables (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add standard Windows manifest to five v8 executables Many executables are missing embedded manifest files when built with gn. This causes OS compatibility information to be omitted which can lead to strange behavior. This change adds a manifest to: v8_simple_json_fuzzer.exe v8_simple_parser_fuzzer.exe v8_simple_regexp_fuzzer.exe v8_simple_wasm_asmjs_fuzzer.exe v8_simple_wasm_fuzzer.exe BUG=chromium:602505 Committed: https://crrev.com/ac03c63c28cd08eb717566166ffb667a741ee71a Cr-Commit-Position: refs/heads/master@{#36725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
4 years, 6 months ago (2016-06-03 23:16:25 UTC) #2
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-04 06:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040623003/1
4 years, 6 months ago (2016-06-04 06:07:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 06:28:11 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 06:29:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac03c63c28cd08eb717566166ffb667a741ee71a
Cr-Commit-Position: refs/heads/master@{#36725}

Powered by Google App Engine
This is Rietveld 408576698