Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <resources xmlns:tools="http://schemas.android.com/tools"> | 6 <resources xmlns:tools="http://schemas.android.com/tools"> |
| 7 <!-- Q: Why put style resources under values-v17/ ? | 7 <!-- Q: Why put style resources under values-v17/ ? |
| 8 A: Problem: | 8 A: Problem: |
| 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. | 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. |
| 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert | 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert |
| (...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 451 <item name="android:textColor">@color/google_blue_700</item> | 451 <item name="android:textColor">@color/google_blue_700</item> |
| 452 <item name="android:textSize">14sp</item> | 452 <item name="android:textSize">14sp</item> |
| 453 </style> | 453 </style> |
| 454 <style name="PaymentsUiSectionDefaultText"> | 454 <style name="PaymentsUiSectionDefaultText"> |
| 455 <item name="android:textColor">@color/default_text_color</item> | 455 <item name="android:textColor">@color/default_text_color</item> |
| 456 <item name="android:textSize">16sp</item> | 456 <item name="android:textSize">16sp</item> |
| 457 </style> | 457 </style> |
| 458 <style name="PaymentsUiSectionDescriptiveText"> | 458 <style name="PaymentsUiSectionDescriptiveText"> |
| 459 <item name="android:textColor">@color/descriptive_text_color</item> | 459 <item name="android:textColor">@color/descriptive_text_color</item> |
| 460 <item name="android:textSize">14sp</item> | 460 <item name="android:textSize">14sp</item> |
| 461 </style> | |
| 462 <style name="PaymentsUiSectionDescriptiveTextEndAligned" parent="PaymentsUiS ectionDescriptiveText"> | |
|
gone
2016/06/03 23:09:54
Doesn't seem to be a line length enforced in this
please use gerrit instead
2016/06/03 23:21:22
You're safe.
| |
| 461 <item name="android:textAlignment">viewEnd</item> | 463 <item name="android:textAlignment">viewEnd</item> |
| 462 </style> | 464 </style> |
| 463 <style name="PaymentsUiSectionAddButtonLabel"> | 465 <style name="PaymentsUiSectionAddButtonLabel"> |
| 464 <item name="android:textColor">@color/light_active_color</item> | 466 <item name="android:textColor">@color/light_active_color</item> |
| 465 <item name="android:textSize">14sp</item> | 467 <item name="android:textSize">14sp</item> |
| 466 <item name="android:textAllCaps">true</item> | 468 <item name="android:textAllCaps">true</item> |
| 467 </style> | 469 </style> |
| 468 | 470 |
| 469 <!-- Misc styles --> | 471 <!-- Misc styles --> |
| 470 <style name="LocationBarButton"> | 472 <style name="LocationBarButton"> |
| (...skipping 18 matching lines...) Expand all Loading... | |
| 489 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton"> | 491 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton"> |
| 490 <item name="android:layout_width">43dp</item> | 492 <item name="android:layout_width">43dp</item> |
| 491 <item name="android:paddingEnd">3.5dp</item> | 493 <item name="android:paddingEnd">3.5dp</item> |
| 492 </style> | 494 </style> |
| 493 <style name="AppMenuItem"> | 495 <style name="AppMenuItem"> |
| 494 <item name="android:paddingStart">16dp</item> | 496 <item name="android:paddingStart">16dp</item> |
| 495 <item name="android:paddingEnd">16dp</item> | 497 <item name="android:paddingEnd">16dp</item> |
| 496 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> | 498 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> |
| 497 </style> | 499 </style> |
| 498 </resources> | 500 </resources> |
| OLD | NEW |