Add support for MAC address randomization

Add support for MAC address randomization

This is a feature in shill/wpa_supplicant to hide MAC addresses
while probing before we are actually connected, making it a little
more difficult to track users' devices by hardware MAC address.
The feature should be disabled for enterprise-enrolled devices
but enabled otherwise.

BUG=579598
R=stevenjb@chromium.org

Committed: https://crrev.com/5c9048b62d7ac578f3cc179afdfec311fbebc305
Cr-Commit-Position: refs/heads/master@{#398717}

[Eric Caruso, 2016-06-04 00:49:04]

PTAL, thanks.

[stevenjb, 2016-06-08 00:35:27]

lgtm w/ added log entry

https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
File chromeos/network/network_device_handler_impl.cc (right):

https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
chromeos/network/network_device_handler_impl.cc:436: const bool enabled) {
Can you add a log entry, e.g.:
NET_LOG(USER) << "Device.MACAddressRandomization: " << (enabled ? "True" :
"False");

THanks.

[Eric Caruso, 2016-06-08 00:42:11]

On 2016/06/08 00:35:27, stevenjb wrote:
> lgtm w/ added log entry
> 
>
https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
> File chromeos/network/network_device_handler_impl.cc (right):
> 
>
https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
> chromeos/network/network_device_handler_impl.cc:436: const bool enabled) {
> Can you add a log entry, e.g.:
> NET_LOG(USER) << "Device.MACAddressRandomization: " << (enabled ? "True" :
> "False");
> 
> THanks.

This is taken care of in Device.SetProperty, no?

[Eric Caruso, 2016-06-08 00:43:46]

https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
File chromeos/network/network_device_handler_impl.cc (right):

https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
chromeos/network/network_device_handler_impl.cc:136: NET_LOG(USER) <<
"Device.SetProperty: " << property_name;
By which I mean this log line right here.

[stevenjb, 2016-06-08 00:52:16]

Ah, cool, nevermind then. lgtm ++


On Tue, Jun 7, 2016 at 5:43 PM, <ejcaruso@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
> File chromeos/network/network_device_handler_impl.cc (right):
>
>
>
https://codereview.chromium.org/2040603002/diff/20001/chromeos/network/networ...
> chromeos/network/network_device_handler_impl.cc:136: NET_LOG(USER) <<
> "Device.SetProperty: " << property_name;
> By which I mean this log line right here.
>
> https://codereview.chromium.org/2040603002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Eric Caruso, 2016-06-08 22:11:36]

The CQ bit was checked by ejcaruso@chromium.org

[Eric Caruso, 2016-06-08 22:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2040603002/#ps40001
(title: "fix FakeNetworkDeviceHandler in unit tests")

[commit-bot: I haz the power, 2016-06-08 22:12:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040603002/40001

[commit-bot: I haz the power, 2016-06-08 23:00:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 23:03:23]

Description was changed from

==========
Add support for MAC address randomization

This is a feature in shill/wpa_supplicant to hide MAC addresses
while probing before we are actually connected, making it a little
more difficult to track users' devices by hardware MAC address.
The feature should be disabled for enterprise-enrolled devices
but enabled otherwise.

BUG=579598
R=stevenjb@chromium.org
==========

to

==========
Add support for MAC address randomization

This is a feature in shill/wpa_supplicant to hide MAC addresses
while probing before we are actually connected, making it a little
more difficult to track users' devices by hardware MAC address.
The feature should be disabled for enterprise-enrolled devices
but enabled otherwise.

BUG=579598
R=stevenjb@chromium.org

Committed: https://crrev.com/5c9048b62d7ac578f3cc179afdfec311fbebc305
Cr-Commit-Position: refs/heads/master@{#398717}
==========

[commit-bot: I haz the power, 2016-06-08 23:03:24]

Patchset 3 (id:??) landed as
https://crrev.com/5c9048b62d7ac578f3cc179afdfec311fbebc305
Cr-Commit-Position: refs/heads/master@{#398717}

[jdufault, 2016-06-14 00:20:09]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2061093002/ by jdufault@chromium.org.

The reason for reverting is: Seeing if this broke tricky (crbug.com/619615)..