Issue 2040593002: Fix IE status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2040593002: Fix IE status (Closed)

Created:
4 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
4 years, 6 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix IE status Committed: https://github.com/dart-lang/sdk/commit/5e9f7a8882c2c87b31aa4ac823360efd36deec49

Patch Set 1 #

Total comments: 1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -58 lines)			Patch
	M	tests/co19/co19-dart2js.status	View		42 chunks	+11 lines, -58 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as 5e9f7a8882c2c87b31aa4ac823360efd36deec49 (presubmit successful).

4 years, 6 months ago (2016-06-03 21:49:11 UTC) #4

Harry Terkelsen

4 years, 6 months ago (2016-06-03 21:52:52 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2040593002/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/2040593002/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:8916:
-LayoutTests/fast/multicol/columns-shorthand-parsing_t02: RuntimeError # Please
triage this failure
so weird... several of these tests went from pass -> error on safari but from
error -> pass on ie

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages