Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4113)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2040573002: [Offlining] Updates the tab helper to use the async OfflinePageModel API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address jianli's nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
index 39cf7d9b0377bf86bb43249c66670d73ab619fc5..06173eacea2d88d0a9f0b27416e7e9476826e093 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
@@ -188,21 +188,23 @@ TEST_F(OfflinePageUtilsTest, MightBeOfflineURL) {
EXPECT_TRUE(OfflinePageUtils::MightBeOfflineURL(GURL("file:///test.mhtml")));
}
-TEST_F(OfflinePageUtilsTest, GetOfflineURLForOnlineURL) {
- EXPECT_EQ(offline_url_page_1(), OfflinePageUtils::GetOfflineURLForOnlineURL(
- profile(), kTestPage1Url));
- EXPECT_EQ(offline_url_page_2(), OfflinePageUtils::GetOfflineURLForOnlineURL(
- profile(), kTestPage2Url));
- EXPECT_EQ(GURL(), OfflinePageUtils::GetOfflineURLForOnlineURL(
+TEST_F(OfflinePageUtilsTest, MaybeGetOfflineURLForOnlineURL) {
+ EXPECT_EQ(offline_url_page_1(),
+ OfflinePageUtils::MaybeGetOfflineURLForOnlineURL(profile(),
+ kTestPage1Url));
+ EXPECT_EQ(offline_url_page_2(),
+ OfflinePageUtils::MaybeGetOfflineURLForOnlineURL(profile(),
+ kTestPage2Url));
+ EXPECT_EQ(GURL(), OfflinePageUtils::MaybeGetOfflineURLForOnlineURL(
profile(), GURL(kTestPage3Url)));
}
-TEST_F(OfflinePageUtilsTest, GetOnlineURLForOfflineURL) {
- EXPECT_EQ(kTestPage1Url, OfflinePageUtils::GetOnlineURLForOfflineURL(
+TEST_F(OfflinePageUtilsTest, MaybeGetOnlineURLForOfflineURL) {
+ EXPECT_EQ(kTestPage1Url, OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
profile(), offline_url_page_1()));
- EXPECT_EQ(kTestPage2Url, OfflinePageUtils::GetOnlineURLForOfflineURL(
+ EXPECT_EQ(kTestPage2Url, OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
profile(), offline_url_page_2()));
- EXPECT_EQ(GURL::EmptyGURL(), OfflinePageUtils::GetOnlineURLForOfflineURL(
+ EXPECT_EQ(GURL::EmptyGURL(), OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
profile(), offline_url_missing()));
}
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698