Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.h

Issue 2040573002: [Offlining] Updates the tab helper to use the async OfflinePageModel API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.h b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
index f14aec4ab0de02dd793c51f67dfe293c9f2788cf..838c4429f349d9c1428c13ba6f9f261269cda5d4 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.h
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
+#include "net/base/net_errors.h"
jianli 2016/06/04 00:27:20 Why is this needed?
dewittj 2016/06/06 16:53:15 Done.
#include "url/gurl.h"
namespace content {
@@ -27,6 +28,8 @@ class OfflinePageTabHelper :
private:
friend class content::WebContentsUserData<OfflinePageTabHelper>;
friend class OfflinePageTabHelperTest;
+ FRIEND_TEST_ALL_PREFIXES(OfflinePageTabHelperTest,
+ NewNavigationCancelsPendingRedirects);
explicit OfflinePageTabHelper(content::WebContents* web_contents);
@@ -36,6 +39,12 @@ class OfflinePageTabHelper :
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+ void GotRedirectURLForSupportedErrorCode(ui::PageTransition transition,
+ const GURL& from_url,
+ const GURL& redirect_url);
+ void GotRedirectURLForStartedNavigation(const GURL& from_url,
+ const GURL& redirect_url);
+
void Redirect(const GURL& from_url, const GURL& to_url);
base::WeakPtrFactory<OfflinePageTabHelper> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698