Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.h

Issue 2040573002: [Offlining] Updates the tab helper to use the async OfflinePageModel API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address jianli's nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
11 #include "content/public/browser/web_contents_user_data.h" 11 #include "content/public/browser/web_contents_user_data.h"
12 #include "url/gurl.h" 12 #include "url/gurl.h"
13 13
14 namespace content { 14 namespace content {
15 class WebContents; 15 class WebContents;
16 } 16 }
17 17
18 namespace offline_pages { 18 namespace offline_pages {
19 19
20 // Per-tab class to manage switch between online version and offline version. 20 // Per-tab class to manage switch between online version and offline version.
21 class OfflinePageTabHelper : 21 class OfflinePageTabHelper :
22 public content::WebContentsObserver, 22 public content::WebContentsObserver,
23 public content::WebContentsUserData<OfflinePageTabHelper> { 23 public content::WebContentsUserData<OfflinePageTabHelper> {
24 public: 24 public:
25 ~OfflinePageTabHelper() override; 25 ~OfflinePageTabHelper() override;
26 26
27 private: 27 private:
28 friend class content::WebContentsUserData<OfflinePageTabHelper>; 28 friend class content::WebContentsUserData<OfflinePageTabHelper>;
29 friend class OfflinePageTabHelperTest; 29 friend class OfflinePageTabHelperTest;
30 FRIEND_TEST_ALL_PREFIXES(OfflinePageTabHelperTest,
31 NewNavigationCancelsPendingRedirects);
30 32
31 explicit OfflinePageTabHelper(content::WebContents* web_contents); 33 explicit OfflinePageTabHelper(content::WebContents* web_contents);
32 34
33 // Overridden from content::WebContentsObserver: 35 // Overridden from content::WebContentsObserver:
34 void DidStartNavigation( 36 void DidStartNavigation(
35 content::NavigationHandle* navigation_handle) override; 37 content::NavigationHandle* navigation_handle) override;
36 void DidFinishNavigation( 38 void DidFinishNavigation(
37 content::NavigationHandle* navigation_handle) override; 39 content::NavigationHandle* navigation_handle) override;
38 40
41 void GotRedirectURLForSupportedErrorCode(ui::PageTransition transition,
42 const GURL& from_url,
43 const GURL& redirect_url);
44 void GotRedirectURLForStartedNavigation(const GURL& from_url,
45 const GURL& redirect_url);
46
39 void Redirect(const GURL& from_url, const GURL& to_url); 47 void Redirect(const GURL& from_url, const GURL& to_url);
40 48
41 base::WeakPtrFactory<OfflinePageTabHelper> weak_ptr_factory_; 49 base::WeakPtrFactory<OfflinePageTabHelper> weak_ptr_factory_;
42 50
43 DISALLOW_COPY_AND_ASSIGN(OfflinePageTabHelper); 51 DISALLOW_COPY_AND_ASSIGN(OfflinePageTabHelper);
44 }; 52 };
45 53
46 } // namespace offline_pages 54 } // namespace offline_pages
47 55
48 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_ 56 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698